Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby: 2.4.5 -> 2.4.7, 2.5.5 -> 2.5.6, 2.6.3 -> 2.6.4 #67976

Merged
merged 4 commits into from Sep 3, 2019
Merged

ruby: 2.4.5 -> 2.4.7, 2.5.5 -> 2.5.6, 2.6.3 -> 2.6.4 #67976

merged 4 commits into from Sep 3, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Sep 3, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: ruby label Sep 3, 2019
@ofborg ofborg bot requested review from manveru and vrthra September 3, 2019 01:17
@ghost
Copy link

ghost commented Sep 3, 2019

Should probably go to staging

manveru
manveru approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@manveru manveru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alyssais
Copy link
Member

alyssais commented Sep 3, 2019 •
edited

< 1000 packages should be fine for master, according to #nixos-dev.

08:44 andi-: qyliss: We had that discussion some time ago and someone came up with ~2500 as a "limit"
08:45 andi-: not sure who that was or if that is the final number but I've been trying to stick with it

@alyssais alyssais merged commit 3a601ca into NixOS:master Sep 3, 2019
@ghost
Copy link

ghost commented Sep 3, 2019

I see

@marsam marsam deleted the update-ruby branch September 3, 2019 16:29
@marsam marsam mentioned this pull request Dec 19, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manveru manveru manveru approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@zimbatm zimbatm Awaiting requested review from zimbatm

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @alyssais @manveru