Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netatalk: fix build #67901

Closed
wants to merge 1 commit into from
Closed

netatalk: fix build #67901

wants to merge 1 commit into from

Conversation

averelld
Copy link
Contributor

@averelld averelld commented Sep 1, 2019

Motivation for this change

Bundles a libevent version (2.0.18?) that is not openssl 1.1 compatible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@averelld
Copy link
Contributor Author

Backport as part of 19.09 / #68361

@lheckemann
Copy link
Member

Upstream gained 1.1 support in Netatalk/netatalk#86, backporting that would probably be nicer.

@ecoughlan
Copy link

I think that is only 1.1.0 support, https://sourceforge.net/p/netatalk/code/ci/master/tree/libevent/ChangeLog (they actually use that as their main repo) indicates they bundle 2.0.18 of libevent, and libevent/libevent#402 shows a newer version that is 1.1.1 incompatible.

@lheckemann lheckemann mentioned this pull request Sep 13, 2019
Merged
10 tasks
@lheckemann
Copy link
Member

I've made a PR that alters netatalk to use our own libevent instead, which seems to work. Would you mind checking that out?

@averelld averelld deleted the netatalk-buildfix branch September 14, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@averelld @lheckemann @ecoughlan