Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bat: 0.11.0 -> 0.12.0 #67868

Merged
merged 1 commit into from Sep 1, 2019
Merged

bat: 0.11.0 -> 0.12.0 #67868

merged 1 commit into from Sep 1, 2019

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Sep 1, 2019

Motivation for this change

https://github.com/sharkdp/bat/releases/tag/v0.12.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lilyball

@Ma27
Copy link
Member

Ma27 commented Sep 1, 2019

Built and tested locally 👍

@Ma27 Ma27 merged commit 46bbe13 into NixOS:master Sep 1, 2019
@Ma27
Copy link
Member

Ma27 commented Sep 1, 2019

@dywedir thanks!

@dywedir dywedir deleted the bat branch September 1, 2019 09:35

nativeBuildInputs = [ cmake pkgconfig zlib ];
nativeBuildInputs = [ pkgconfig llvmPackages.libclang zlib ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this change? The README still says you need cmake.

Copy link
Member

@lilyball lilyball Sep 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does build on my system with this change. I'm not sure why cmake was required to begin with though, was it one of the bat dependencies? If it's not actually required then we should file an upstream issue to update the README.

Edit: I went ahead and filed sharkdp/bat#649 about removing cmake from the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants