Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.flask: 1.0.3 -> 1.0.4 #67925

Merged
merged 1 commit into from Sep 2, 2019
Merged

pythonPackages.flask: 1.0.3 -> 1.0.4 #67925

merged 1 commit into from Sep 2, 2019

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Sep 2, 2019

Motivation for this change

A recent pytest update broke this package and others, which is an issue that the 1.0.4 release addresses. There is also #64332 which would supercede this, though it's been sitting for a while now so I'm submitting this in case a minor version bump is more palatable or likely to cause less breakage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@arcnmx arcnmx requested a review from FRidh as a code owner September 2, 2019 07:23
@FRidh
Copy link
Member

FRidh commented Sep 2, 2019

@GrahamcOfBorg build python3.pkgs.flask

@teto teto merged commit becf5ad into NixOS:master Sep 2, 2019
@teto
Copy link
Member

teto commented Sep 2, 2019

thanks that unblocked quite a few python pacakges.

@teto teto mentioned this pull request Sep 2, 2019
Closed
@arcnmx arcnmx deleted the flask-1.0.4 branch November 26, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arcnmx @FRidh @teto