Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should memory read ports use domain="comb" or domain=None instead of synchronous=False? #116

Closed
whitequark opened this issue Jun 29, 2019 · 3 comments
Closed

Should memory read ports use domain="comb" or domain=None instead of synchronous=False? #116

whitequark opened this issue Jun 29, 2019 · 3 comments
Labels
bug
Milestone
0.1

Comments

@whitequark
Copy link
Contributor

It feels odd to have the memory.read_port(domain="sync", synchronous=False) combination of arguments to be valid, and in fact that seems like it'd cause some hard to find bugs.
@whitequark whitequark added this to the 0.1 milestone Jun 29, 2019
@whitequark whitequark added bug and removed question labels Jul 1, 2019
@sbourdeauducq
Copy link
Member

Why not domain=None? comb is a valid, albeit ill-chosen, name for a synchronous domain.

@sbourdeauducq sbourdeauducq reopened this Jul 3, 2019
@whitequark
Copy link
Contributor Author

@sbourdeauducq Because of the way Module is implemented, trying to do m.d.comb += stmt or m.d["comb"] += stmt will always add those statements to the combinatorial domain, even if there is a synchronous domain called comb.

So I wouldn't say it's valid, and further, we probably need to disallow either creating a ClockDomain("comb") or adding it to any module.

@whitequark
Copy link
Contributor Author

Closing per IRC discussion.

Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
2 participants
@whitequark @sbourdeauducq