Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[idlharness] Check exposure set after inheritance #17560

Closed
wants to merge 2 commits into from
Closed

[idlharness] Check exposure set after inheritance #17560

wants to merge 2 commits into from

Conversation

lukebjerring
Copy link
Contributor

Fixes #17551

Assert that the exposure set for the inheritor is a subset of the base.

@lukebjerring lukebjerring mentioned this pull request Jun 28, 2019
Merged
@lukebjerring lukebjerring mentioned this pull request Jun 28, 2019
Open
@lukebjerring lukebjerring reopened this Jul 25, 2019
@lukebjerring
Copy link
Contributor Author

Part of #8053

@lukebjerring lukebjerring added this to Done in Improve idlharness.js via automation Aug 15, 2019
@lukebjerring lukebjerring reopened this Aug 15, 2019
Improve idlharness.js automation moved this from Done to In progress Aug 15, 2019
@foolip
Copy link
Member

foolip commented Oct 23, 2019

I'll rebase this to see what effect it'd have now.

@foolip
Copy link
Member

foolip commented Oct 23, 2019

Closing in favor of the webidl2.js validation approach: #17551 (comment)

@foolip foolip closed this Oct 23, 2019
Improve idlharness.js automation moved this from In progress to Done Oct 23, 2019
@foolip foolip deleted the exposed branch October 23, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsnedders gsnedders Awaiting requested review from gsnedders

@jgraham jgraham Awaiting requested review from jgraham

Assignees

@gsnedders gsnedders

Labels
idlharness.js infra testharness.js
Projects
No open projects
Improve idlharness.js
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[idlharness] Interface inheritance does not assert exposure is a subset
4 participants
@lukebjerring @foolip @gsnedders @wpt-pr-bot