Lets just get rid of the pkgs argument altogether. To make sure we're not making more mistakes like this. Because I assume the ./examples stuff doesn't work either with cross compilation now; does it?

@arianvp Good point. I am going to try out, and maybe also fix, the examples, too.

@arianvp examples are still solid.

Great. LGTM!

@GrahamcOfBorg test docker-tools

@GrahamcOfBorg test docker-tools

There seemed to have been some kind of transient failure

Alas, the error doesn't seem to be transient on x86_64 https://logs.nix.ci/?key=nixos/nixpkgs.63865&attempt_id=91cb4421-6100-4582-9c07-25d92ee2f597 Not sure what is going on here.

@arianvp I notice that on master (aka. f3282c8#diff-f5fad34a5e280fe300df690ac61dc673), dockerTools.examples.nginx cannot build already. I am doing a bisect.

@arianvp This is the reason for that error: 4a4561c#diff-f5fad34a5e280fe300df690ac61dc673R122

It is deleting the VM drive before qemu exits, which makes it panic.

@GrahamcOfBorg test docker-tools

I think I just spawned a test seconds before you force-pushed. So it might fail again haha

@GrahamcOfBorg test docker-tools

Hmm, the test seems to time out on x86_64 whilst docker load'ing the container. that doesn't sound good :/

@arianvp I tried the docker load command locally with the x86_64 image, and it works fine.

I want to try running these tests locally. How can I run this specific test?

nix-build ./nixos/tests/docker-tools.nix

@arianvp Work fine here. I cannot reproduce the timeout.

See the gist:
https://gist.github.com/dingxiangfei2009/91b7d763853f4c6823e310792adf420f

@dingxiangfei2009 the reason is that not all build machines support nested kvm, so they emulate x86 and are slow. so this is why it's failing. Not because there is something wrong with the test.

Lets get this merged

This looks correct to me and I don't think there should be a reason to suspect that it should be slower on Hydra than the current release-blocker docker test. Let's keep an eye on it regardless. :)