Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulseaudio-modules-bt: Patch default settings for AAC encoding #63859

Merged
merged 1 commit into from Jun 27, 2019
Merged

pulseaudio-modules-bt: Patch default settings for AAC encoding #63859

merged 1 commit into from Jun 27, 2019

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Jun 27, 2019

Motivation for this change

The upstream defaults result in audibly worse quality than simply
relying on the builtin SBC codec, making it somewhat useless. Attempt
to fix this by setting saner defaults.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz
pulseaudio-modules-bt: Patch default settings for AAC encoding
700bab5 
The upstream defaults result in audibly worse quality than simply
relying on the builtin SBC codec, making it somewhat useless. Attempt
to fix this by setting saner defaults.
@adisbladis adisbladis merged commit 277f865 into NixOS:master Jun 27, 2019
@ofborg ofborg bot requested a review from adisbladis June 27, 2019 15:12
@talyz talyz deleted the fix-aac-defaults branch June 27, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@talyz @adisbladis