Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-recent: 1.1.0 -> 1.1.1 #63943

Merged
merged 1 commit into from Jun 30, 2019
Merged

git-recent: 1.1.0 -> 1.1.1 #63943

merged 1 commit into from Jun 30, 2019

Conversation

jlesquembre
Copy link
Member

Motivation for this change

git-recent: 1.1.0 -> 1.1.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto teto merged commit e295fd8 into NixOS:master Jun 30, 2019
@teto
Copy link
Member

teto commented Jun 30, 2019

Is it normal to have

$ git recent
error: option `count' expects a numerical value

?
I thought the number was optional. $ git recent -n5 works

@jlesquembre
Copy link
Member Author

v1.1.1 was supposed to fix that issue:
paulirish/git-recent#19

for me git recent, without -n, works

@teto
Copy link
Member

teto commented Jun 30, 2019

ok I am still running 1.1.0 . Thanks for the explanation.

@jlesquembre jlesquembre deleted the git-recent branch June 30, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jlesquembre @teto