Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mautrix-telegram: 0.5.2 -> 0.6.0 #63947

Merged
merged 4 commits into from Jul 9, 2019
Merged

mautrix-telegram: 0.5.2 -> 0.6.0 #63947

merged 4 commits into from Jul 9, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Jun 30, 2019 •
edited

Motivation for this change

Draft pull request in prevision of mautrix-telegram 0.6.0

Also update:

  • mautrix-appservice: 0.3.10.dev1 -> 0.3.11
  • telethon: 1.6.2 -> 1.9.0
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Ma27 June 30, 2019 10:19
This was referenced Jul 1, 2019
Merged
Closed
@nyanloutre nyanloutre changed the title mautrix-telegram: 0.5.2 -> 0.6.0-rc1 mautrix-telegram: 0.5.2 -> 0.6.0-rc2 Jul 6, 2019
@nyanloutre nyanloutre changed the title mautrix-telegram: 0.5.2 -> 0.6.0-rc2 mautrix-telegram: 0.5.2 -> 0.6.0 Jul 9, 2019
@nyanloutre nyanloutre marked this pull request as ready for review July 9, 2019 16:56
@nyanloutre nyanloutre requested a review from FRidh as a code owner July 9, 2019 16:56
@nyanloutre
Copy link
Member Author

Stable is out, this can be merged now

@Ma27
Copy link
Member

Ma27 commented Jul 9, 2019

Nice! I'll deploy that later that evening to my Matrix HS and merge this if everything goes well :)

@Ma27
Copy link
Member

Ma27 commented Jul 9, 2019

Deployed to my Matrix HS, upgrade went well, I can still send/receive messages 👍

@Ma27 Ma27 merged commit 3fe8d63 into NixOS:master Jul 9, 2019
@Ma27
Copy link
Member

Ma27 commented Jul 9, 2019

@nyanloutre thanks!

@Ma27
Copy link
Member

Ma27 commented Jul 9, 2019

Oh btw @nyanloutre do you think that we should backport this?

@nyanloutre nyanloutre deleted the mautrix_telegram_0_6_0 branch July 9, 2019 22:42
@nyanloutre
Copy link
Member Author

Yes you could but the module #63589 will not be available in 19.03

@Ma27
Copy link
Member

Ma27 commented Jul 9, 2019

Yes you could but the module #63589 will not be available in 19.03

Yeah, I know that :)
But there are probably some more people like me who are running mautrix-telegram with a custom service.

@Ma27
Copy link
Member

Ma27 commented Jul 9, 2019

Tested and backported as ee942c3, a2e4386, 41d303c, 28e64db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer left review comments

@Ma27 Ma27 Ma27 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyanloutre @Ma27 @matthiasbeyer