Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.plat: fix dedent overrides. #111

Merged
merged 1 commit into from Jun 28, 2019
Merged

Conversation

peteut
Copy link
Contributor

@peteut peteut commented Jun 27, 2019

This fixes commit ecf673d for Iterable overrides.

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #111 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   80.77%   80.73%   -0.04%     
==========================================
  Files          32       32              
  Lines        5024     5005      -19     
  Branches     1088     1080       -8     
==========================================
- Hits         4058     4041      -17     
  Misses        831      831              
+ Partials      135      133       -2
Impacted Files Coverage Δ
nmigen/build/plat.py 23.31% <0%> (-0.29%) ⬇️
nmigen/hdl/ir.py 94.26% <0%> (-0.08%) ⬇️
nmigen/back/pysim.py 96.62% <0%> (-0.02%) ⬇️
nmigen/hdl/xfrm.py 96.2% <0%> (-0.02%) ⬇️
nmigen/hdl/dsl.py 99.28% <0%> (ø) ⬆️
nmigen/hdl/ast.py 86.82% <0%> (+0.05%) ⬆️
nmigen/back/rtlil.py 86.58% <0%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0a7f84...9c86b33. Read the comment docs.

@whitequark
Copy link
Contributor

I don't understand what does this fix actually do.

@peteut
Copy link
Contributor Author

peteut commented Jun 28, 2019

Some overrides, for instance vivado_opts expecting a list of strings, not a string.
ecf673d does not check for that and introduced the regression.

@whitequark
Copy link
Contributor

Thanks. I don't think there is any need to dedent overrides provided as a list. Can you change it so that it only dedents strings?

@whitequark whitequark merged commit 1609a5b into m-labs:master Jun 28, 2019
@peteut
Copy link
Contributor Author

peteut commented Jun 28, 2019

Thanks and sorry for the mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants