Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyls bumping #63847

Merged
merged 2 commits into from Jul 17, 2019
Merged

Pyls bumping #63847

merged 2 commits into from Jul 17, 2019

Conversation

teto
Copy link
Member

@teto teto commented Jun 27, 2019

Motivation for this change

there were some bugs in pyls-mypy (would crash with coc). With this update it looks ok

Pinging @jabranham since he made the last python-language-server update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto teto requested a review from FRidh as a code owner June 27, 2019 04:54
@ofborg ofborg bot requested a review from Mic92 June 27, 2019 05:05
@FRidh FRidh merged commit 2cd8924 into NixOS:master Jul 17, 2019
@teto teto deleted the pyls branch July 17, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants