Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/redmine: add database.createLocally option #63932

Merged
merged 2 commits into from Jul 14, 2019
Merged

nixos/redmine: add database.createLocally option #63932

merged 2 commits into from Jul 14, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

aanderse commented Jun 29, 2019 •
edited

@GrahamcOfBorg test redmine.v4-mysql
@GrahamcOfBorg test redmine.v4-pgsql

@aanderse
Copy link
Member Author

aanderse commented Jul 5, 2019 •
edited

machine# [ 502.934336] systemd[1]: redmine.service: Start-pre operation timed out. Terminating.

😥

@aanderse
Copy link
Member Author

@GrahamcOfBorg test redmine.v4-mysql

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/25

infinisil
infinisil approved these changes Jul 14, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looking good!

@infinisil infinisil merged commit 5eac339 into NixOS:master Jul 14, 2019
@aanderse
Copy link
Member Author

Thanks @infinisil!

@aanderse aanderse deleted the redmine branch July 14, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @nixos-discourse @infinisil