Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plex-media-player: 2.23.0 -> 2.36.0 #63878

Merged
merged 1 commit into from Jul 3, 2019

Conversation

solson
Copy link
Member

@solson solson commented Jun 28, 2019

Motivation for this change

Updates Plex Media Player to version 2.36.0.988-0150ae52

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

aanderse commented Jul 1, 2019

@GrahamcOfBorg build plex-media-player

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added plex-media-player = libsForQt59.callPackage <solus/plex-media-player-update>/applications/video/plex-media-player { }; to my local overlay, built, ran application, tried to click around a bit but was disappointed when a login was required. 🤷‍♂️ LGTM 👍

@aanderse aanderse merged commit ed952d4 into NixOS:master Jul 3, 2019
@solson solson deleted the plex-media-player-update branch July 3, 2019 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants