Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGoModule: add ./ to all sub-packages #63936

Merged
merged 1 commit into from Jun 30, 2019
Merged

buildGoModule: add ./ to all sub-packages #63936

merged 1 commit into from Jun 30, 2019

Conversation

kalbasit
Copy link
Member

Motivation for this change

When $subPackages has more than one item, the build was failing because ./ was added only to the first subPackage. This commit adds ./ to all specified subPackages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

closes #63923

cc @gazally @worldofpeace

@kalbasit
buildGoModule: add ./ to all sub-packages
afb0b52 
When $subPackages has more than one item, the build was failing because
./ was added only to the first subPackage. This commit adds ./ to all
specified subPackages.
@kalbasit
Copy link
Member Author

@GrahamcOfBorg build pdfcpu hugo golangci-lint caddy jx rclone

@kalbasit
Copy link
Member Author

@gazally your package now works on my side. Please try it on your side and LMK so I can merge.

@gazally
Copy link
Contributor

gazally commented Jun 30, 2019

I tried it and it works now, thanks.

@kalbasit
Copy link
Member Author

Thank you for trying it. I'll merge this then.

@kalbasit kalbasit merged commit 1474220 into NixOS:master Jun 30, 2019
@kalbasit kalbasit deleted the nixpkgs_fix-build-go-module-subpackages branch June 30, 2019 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

buildGoModule fails to build derivations with more than one subPackage
2 participants
@kalbasit @gazally