cc @eadwu

huh darwin is failing to configure at

meson.build:368:4: ERROR: Problem encountered: Cannot build GLX support without X11 platform support and at least one OpenGL API

Removing the option should be fine while for the darwin error, from what I'm reading it seems to originate from here [1]. If we don't want to change -Dglx for darwin then there should be a non-zero amount of gallium or dri drivers, -Ddri-drivers= -Dgallium-drivers= -Dvulkan-drivers= [2].

[1] https://gitlab.freedesktop.org/mesa/mesa/blob/19.1/meson.build#L315
[2] https://hydra.nixos.org/build/95553754/log

Removing the option should be fine while for the darwin error, from what I'm reading it seems to originate from here [1]. If we don't want to change -Dglx for darwin then there should be a non-zero amount of gallium or dri drivers, -Ddri-drivers= -Dgallium-drivers= -Dvulkan-drivers= [2].

[1] https://gitlab.freedesktop.org/mesa/mesa/blob/19.1/meson.build#L315
[2] https://hydra.nixos.org/build/95553754/log

That looks like a mesa issue. The whole point of the appledri is to have GLX without building opengl drivers. Otherwise you wouldn't be building anything at all[1]. For now it's probably okay for this to be broken, luckily not much macOS stuff uses it right now (it only makes sense if you are using XQuartz as well).

[1] https://gitlab.freedesktop.org/mesa/mesa/blob/19.1/src/glx/apple/RELEASE_NOTES

Issue filed at https://bugs.freedesktop.org/show_bug.cgi?id=111016

Thanks for filing an issue upstream @matthewbauer.
I agree it's fine to leave it broken for darwin.

Let's merge ✨

Well, the darwin problem probably blocks merging to master, due to breaking a few thousand darwin builds. Lemme try this: #64500