Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2019.06.21 -> 2019.06.27 #63880

Merged
merged 1 commit into from Jun 28, 2019
Merged

youtube-dl: 2019.06.21 -> 2019.06.27 #63880

merged 1 commit into from Jun 28, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Jun 28, 2019 •
edited

Motivation for this change

Update youtube-dl to the latest release.
https://github.com/ytdl-org/youtube-dl/releases/tag/2019.06.27
NOTE: Updates to youtube-dl should be backported, thanks!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fpletz fpletz merged commit 5a5245e into NixOS:master Jun 28, 2019
@xrelkd xrelkd deleted the update/youtube-dl branch June 28, 2019 15:34
@xrelkd
Copy link
Contributor Author

xrelkd commented Jun 28, 2019

@fpletz Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xrelkd @fpletz