New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/mysql: run ExecStartPost as root (again) to preserve compatibility with secured installs #63862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@GrahamcOfBorg test mysql mysqlbackup |
@thorstenweber83 is this an adequate solution to your problems with |
flokli
reviewed
Jun 30, 2019
@aanderse yes, looks like this will fix my issue. |
aanderse
force-pushed
the
mysql-fix
branch
3 times, most recently
from
July 1, 2019 01:40
b0215fd
to
a186101
Compare
…ity with installs that have been secured
Sorry, bit of a git mess there for a moment. All good now. @flokli I have made the changes you requested so I'll leave this up to you to merge if you accept. |
Thanks a lot! |
Thank you very much! |
10 tasks
peterhoeg
pushed a commit
to peterhoeg/nixpkgs
that referenced
this pull request
Jul 3, 2019
peterhoeg
pushed a commit
to peterhoeg/nixpkgs
that referenced
this pull request
Jul 3, 2019
nixos/mysql: fix mysql test after NixOS#63862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Partial revert of #61589 as it breaks
ensureDatabases
andensureUsers
on systems wheremysql
has been secured.For examples of broken setups:
#61589 (comment)
#63634 (comment)
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)