Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/mysql: run ExecStartPost as root (again) to preserve compatibility with secured installs #63862

Merged
merged 3 commits into from Jul 1, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change

Partial revert of #61589 as it breaks ensureDatabases and ensureUsers on systems where mysql has been secured.

For examples of broken setups:
#61589 (comment)
#63634 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse requested a review from flokli June 27, 2019 16:54
@aanderse aanderse assigned danbst and globin and unassigned danbst and globin Jun 27, 2019
@aanderse
Copy link
Member Author

aanderse commented Jun 27, 2019

@GrahamcOfBorg test mysql mysqlbackup

@aanderse
Copy link
Member Author

@thorstenweber83 is this an adequate solution to your problems with mysql?

@thorstenweber83
Copy link
Contributor

@aanderse yes, looks like this will fix my issue.

@aanderse
Copy link
Member Author

aanderse commented Jul 1, 2019

Sorry, bit of a git mess there for a moment. All good now.

@flokli I have made the changes you requested so I'll leave this up to you to merge if you accept.

@flokli
Copy link
Contributor

flokli commented Jul 1, 2019

Thanks a lot!

@flokli flokli merged commit 51bcf11 into NixOS:master Jul 1, 2019
@thorstenweber83
Copy link
Contributor

Thank you very much!

@aanderse aanderse deleted the mysql-fix branch July 1, 2019 10:39
peterhoeg pushed a commit to peterhoeg/nixpkgs that referenced this pull request Jul 3, 2019
peterhoeg pushed a commit to peterhoeg/nixpkgs that referenced this pull request Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants