Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to automatically rebuild with entr #288

Merged
merged 4 commits into from Mar 16, 2020
Merged

Conversation

egasimus
Copy link
Contributor

Adding the Event Notify Task Runner to the build environment makes development faster by allowing the site to automatically rebuild in the background upon changing the source files.

@egasimus
Copy link
Contributor Author

This tiny addition is a stepping stone to further contributions planned. You people are doing great work and I'm looking forward to helping out!

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a useful tip

@garbas garbas merged commit 9d072d1 into NixOS:master Mar 16, 2020
export NIXOS_AZURE_BLOBS="${packages.x86_64-linux.nixosAzureBlobs}"
export PACKAGES_EXPLORER="${packages.x86_64-linux.packagesExplorer}/bundle.js"
export NIX_PILLS_MANUAL_IN="${packages.x86_64-linux.nixPills}/share/doc/nix-pills"
'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot of code duplication, is that really necessary?

@edolstra
Copy link
Member

Do we actually still need this? It only takes a few seconds to build the homepage, so adding a dependency that we generally don't need and duplicating makeFlags in shellHook is a bit suboptimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants