Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keepassxc: 2.4.1 -> 2.4.3 #63939

Closed
wants to merge 1 commit into from
Closed

Conversation

jonafato
Copy link
Contributor

Upgrade keepassxc to 2.4.3. Full changelog available at
https://github.com/keepassxreboot/keepassxc/releases/tag/2.4.3.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@taku0
Copy link
Contributor

taku0 commented Jun 30, 2019

It works fine on NixOS with sandbox.

@Mic92
Copy link
Member

Mic92 commented Jul 1, 2019

@GrahamcOfBorg build keepassxc

@jonafato
Copy link
Contributor Author

jonafato commented Jul 3, 2019

@bobvanderlinden Any chance you can test this on macOS?

@bobvanderlinden
Copy link
Member

On OSX I see the following error while building:

[ 15%] Building CXX object tests/CMakeFiles/testsupport.dir/FailDevice.cpp.o
/private/var/folders/ch/l7_3t7z12hb34k98lqkt27yw0000gp/T/nix-build-keepassxc-2.4.3.drv-0/source/src/core/Alloc.cpp:63:5: error: call to unavailable function 'operator delete': introduced in macOS 10.12
    ::operator delete(ptr, malloc_size(ptr));
    ^~~~~~~~~~~~~~~~~
/private/var/folders/ch/l7_3t7z12hb34k98lqkt27yw0000gp/T/nix-build-keepassxc-2.4.3.drv-0/source/src/core/Alloc.cpp:35:6: note: candidate function has been explicitly made unavailable
void operator delete(void* ptr, std::size_t size) noexcept
     ^
/nix/store/5yismw8d67dxddvlcj7i3avkq8gzyb6h-libc++-7.1.0/include/c++/v1/new:188:36: note: candidate function not viable: no known conversion from 'size_t' (aka 'unsigned long') to 'const std::nothrow_t' for 2nd argument
_LIBCPP_OVERRIDABLE_FUNC_VIS void  operator delete(void* __p, const std::nothrow_t&) _NOEXCEPT;
                                   ^
/nix/store/5yismw8d67dxddvlcj7i3avkq8gzyb6h-libc++-7.1.0/include/c++/v1/new:221:40: note: candidate function not viable: no known conversion from 'size_t' (aka 'unsigned long') to 'void *' for 2nd argument
inline _LIBCPP_INLINE_VISIBILITY void  operator delete  (void*, void*) _NOEXCEPT {}
                                       ^
/private/var/folders/ch/l7_3t7z12hb34k98lqkt27yw0000gp/T/nix-build-keepassxc-2.4.3.drv-0/source/src/core/Alloc.cpp:54:6: note: candidate function not viable: requires single argument 'ptr', but 2 arguments were provided
void operator delete(void* ptr) noexcept
     ^
1 error generated.

I have looked online how to solve this, but it seems this needs an upgrade of apple-sdk?

@Mic92
Copy link
Member

Mic92 commented Jul 4, 2019

Is this a recent regression on macOS or has this been there before?

@worldofpeace
Copy link
Contributor

Appears to be new https://hydra.nixos.org/build/95437784

@bobvanderlinden
Copy link
Member

Building 1707911f972bae8cb5240cde6d4bd7261b693577 succeeded. Building cd6e17e691b76fbd1ffd294769ef69336de94ff2 did not.

@jonafato jonafato mentioned this pull request Jul 18, 2019
10 tasks
Upgrade keepassxc to 2.4.3. Full changelog available at
https://github.com/keepassxreboot/keepassxc/releases/tag/2.4.3.
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build keepassxc

@jonafato
Copy link
Contributor Author

Closing in favor of #66572.

@jonafato jonafato closed this Aug 15, 2019
@jonafato jonafato deleted the keepassxc-2.4.3 branch August 15, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants