Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomad: 0.8.7 -> 0.9.3 #63854

Merged
merged 1 commit into from Jul 1, 2019
Merged

nomad: 0.8.7 -> 0.9.3 #63854

merged 1 commit into from Jul 1, 2019

Conversation

knl
Copy link
Contributor

@knl knl commented Jun 27, 2019

0.9 series require go 1.11.11+ so switching to default 1.12.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg
Copy link
Member

JohnAZoidberg commented Jun 27, 2019

Builds fine on NixOS but when I try to run it, I get:

[nix-shell:~/.cache/nix-review/pr-63854]$ ./results/nomad/bin/nomad --version
./results/nomad/bin/nomad: symbol lookup error: ./results/nomad/bin/nomad: undefined symbol: nvmlDeviceGetGraphicsRunningProcesses

@risicle
Copy link
Contributor

risicle commented Jun 27, 2019

nox-review builds for me, non-nixos linux x86_64. Same issue as @JohnAZoidberg though.

@JohnAZoidberg
Copy link
Member

@risicle Does it also run for you?
I'm on NixOS x86_64.

@knl
Copy link
Contributor Author

knl commented Jun 28, 2019

For me, it builds and works on macOS:

[nix-shell:~/.cache/nix-review/pr-63854]$ ./results/nomad/bin/nomad --version
Nomad v0.9.3

0.9 series require go 1.11.11+ so switching to default 1.12.
@knl
Copy link
Contributor Author

knl commented Jun 28, 2019

@JohnAZoidberg @risicle Please take another look. I added -tags nonvidia which disables nVidia support and now it works even on NixOS:

[nikola@zrh-3:~/nixpkgs]$ result-bin/bin/nomad --version
Nomad v0.9.3

Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, works on x64 NixOS.

@risicle
Copy link
Contributor

risicle commented Jun 28, 2019

👍 WFM now non-nixos linux x86_64 & macos 10.13

@arianvp
Copy link
Member

arianvp commented Jun 30, 2019

Getting NVIDIA to work should be possible. We could add nvidia_x11 as an optional dependency and do some patchelf'ing. However We could also merge as is, and document somewhere that we lack NVIDIA support.

@knl
Copy link
Contributor Author

knl commented Jul 1, 2019

@arianvp where should I document it? As I don't have a machine to test with nvidia_x11, I'd rather take the other option.

@danbst
Copy link
Contributor

danbst commented Jul 1, 2019

There is clearly some magic here, as Hashicorp-released binary, packaged with Nix tools, doesn't have this problem and unresolved NVIDIA symbols cause no problems. I'm using this expression:

    nomad-binary = pkgs.stdenv.mkDerivation rec {
        name = "nomad-${src.meta.version}";
        src = pkgs.fetchzip rec {
            url = "https://releases.hashicorp.com/nomad/${meta.version}/nomad_${meta.version}_linux_amd64.zip";
            meta.version = "0.9.3";
            sha256 = "1hcz2mqzavimyibb1512gxwmpxn4c9xmca1gqsp0lawq4njc7zgm";
        };
        nativeBuildInputs = [
            pkgs.autoPatchelfHook
        ];
        installPhase = ''
          mkdir -p $out/bin
          cp * $out/bin/
        '';
    };

@danbst danbst merged commit 5366173 into NixOS:master Jul 1, 2019
@danbst
Copy link
Contributor

danbst commented Jul 1, 2019

I went ahead and merged as-is. NVIDIA support can be done later (if ever wanted).

Thanks all!

@knl knl deleted the nomad-0.9.3 branch March 18, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants