Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yggdrasil: init at 0.3.5 #63855

Closed
wants to merge 1 commit into from
Closed

yggdrasil: init at 0.3.5 #63855

wants to merge 1 commit into from

Conversation

Lassulus
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

gazally
gazally reviewed Jun 27, 2019
View reviewed changes
Copy link
Contributor

@gazally gazally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I've been trying out yggdrasil lately too. The derivation I wrote uses buildGoModule and I also have a NixOS service module and I will put both into a pull request shortly so you can see them.

I just built your derivation on my system and it works for me.

pkgs/tools/networking/yggdrasil/default.nix Outdated Show resolved Hide resolved
@Lassulus
Copy link
Member Author

@gazally cool, do you want to rebase your service on this package or should we wait?
I'm also not sure what buildGoModule does in this context.

@gazally gazally mentioned this pull request Jun 27, 2019
Closed
10 tasks
@Lassulus
Copy link
Member Author

Lassulus commented Jul 1, 2019

I will close this in favor of #63863

@Lassulus Lassulus closed this Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gazally gazally gazally left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lassulus @gazally