Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel-buildtools: 0.22.0 -> 0.26.0 #63856

Closed
wants to merge 1 commit into from

Conversation

u-quark
Copy link
Contributor

@u-quark u-quark commented Jun 27, 2019

Motivation for this change

Update to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Profpatsch
Copy link
Member

You have to update the dependencies as well. I’ll add the commit.

@Profpatsch
Copy link
Member

@uri-canva buildTools is not a go package, but uses bazel. It’s not really clear to me how the dependencies should be updated.

@u-quark
Copy link
Contributor Author

u-quark commented Jun 28, 2019

@Profpatsch I am assuming we should use go2nix but I haven't looked more into it.

@uri-canva
Copy link
Contributor

Yes, that is correct, there's also a newer mechanism buildGoModule but I don't think we can use that for this particular derivation because it's missing the required files: https://kalbas.it/2019/03/17/announcing-the-new-golang-infrastructure-buildgomodule/.

@Profpatsch
Copy link
Member

I’m unsure whether we should merge this without also making sure the dependencies are up-to-date.

@uri-canva
Copy link
Contributor

I think it's better not to, even if superficial testing might show it to be working, there might be subtle bugs compared to upstream if we're not using the same versions of dependencies.

@u-quark
Copy link
Contributor Author

u-quark commented Jul 9, 2019

Closing in favor of #64537 bumping to an even newer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants