minecraft-server: 1.14 -> 1.14.3 #63848
Conversation
|
I have no problem with this being done. But is this pattern being done for other software? For example postgresql has multiple versions in the all-packages namespace. https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L14635. Obviously postgresql versions are more important that minecraft-server versions so rules may not apply to this package. |
|
I don't know of any cases where this is done currently. TBH, I think the best option would probably be to remove the older versions from nixpkgs entirely and only have the latest. |
|
@infinisil and @calbrecht have any thoughts on removing older versions of minecraft server? My thoughts are that older versions are valuable since diferent server versions are entirely different minecraft worlds |
|
Actually, people can always use older versions by using an older nixpkgs version, which is really unproblematic because of how Nix works. So even though only recently these multiple versions have been introduced, I wouldn't mind only having the latest version in the future. |
|
Great point. Sounds good with me to remove the old versions |
| inherit (callPackages ../games/minecraft-server { }) | ||
| minecraft-server_1_14 | ||
| minecraft-server_1_13_2 | ||
| minecraft-server_1_12_2; |
There was a problem hiding this comment.
Would you mind adding aliases for these? I think it's good practice to strive for backwards compatibility, deprecation and better error messages
There was a problem hiding this comment.
I would mind:
- It's cruft
- We have precedent for removing old minecraft server versions without notice: c7b36b7
- This pull request is to master, which goes to unstable, and isn't expected to maintain backwards compatibility.
There was a problem hiding this comment.
Okay well I'm okay with doing it in this case, because these versions have only been introduced recently and aren't in the last release.
Also removes older versions.
lheckemann
force-pushed
the
mc-server-bump
branch
from
0fa8ed8
to
5d04dcf
Compare
|
This pull request has been mentioned on Nix community. There might be relevant details there: |
Also removes older versions from the top level of nixpkgs. They can
still be accessed via minecraft-server-versions. This allows leaving
all-packages.nix alone in future server bumps.
cc @thoughtpolice @tomberek @costrouc — would very much appreciate your input on this because it's a minor breaking change.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)