New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
galario: init at 1.2.1 #63853
galario: init at 1.2.1 #63853
Conversation
@GrahamcOfBorg build python3Packages.galario python2Packages.galario |
|
Co-Authored-By: Daniel Schaefer <git@danielschaefer.me>
@GrahamcOfBorg build python3Packages.galario python2Packages.galario galario |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NixOS (x86_64-linux)
2 package failed to build:
python37Packages.galario python38Packages.galario
2 package were build:
galario python27Packages.galario
and same on darwin.
Otherwise LGTM
|
||
buildInputs = [ fftw fftwFloat ] | ||
++ stdenv.lib.optional enablePython pythonPackages.python | ||
++ stdenv.lib.optional stdenv.isDarwin llvmPackages.openmp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ stdenv.lib.optional stdenv.isDarwin llvmPackages.openmp | |
++ stdenv.lib.optional stdenv.cc.isClang llvmPackages.openmp |
preCheck = '' | ||
${if stdenv.isDarwin then "export DYLD_LIBRARY_PATH=$(pwd)/src/" else "export LD_LIBRARY_PATH=$(pwd)/src/"} | ||
${if enablePython then "sed -i -e 's|^#!.*|#!${stdenv.shell}|' python/py.test.sh" else ""} | ||
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually don't use interpolation to add two strings.
preCheck = ''
export ${stdenv.optionalString stdenv.isDarwin "DY"}LD_LIBRARY_PATH=$(pwd)/src/
'' + (stdenv.optionalString enablePython ''
sed -i -e 's|^#!.*|#!${stdenv.shell}|' python/py.test.sh
'');
@GrahamcOfBorg build python3Packages.galario python2Packages.galario galario |
Motivation for this change
Package galario for Nix.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)