Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clipgrab: 3.8.2 -> 3.8.3 #63872

Closed
wants to merge 2 commits into from
Closed

Conversation

MarcFontaine
Copy link
Contributor

Motivation for this change

clipgrap 3.8.2 no longer works with Youtube

Things done

Update clipgrab from 3.8.2 to 3.8.3

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg evals
  • run nix-review without any failures
  • run and tested the binaries

@worldofpeace
Copy link
Contributor

@MarcFontaine Can you add a comment like in youtube-dl

# The websites youtube-dl deals with are a very moving target. That means that

I will backport updates to this since it's definitely broken on stable.

@worldofpeace
Copy link
Contributor

Merged in 17fafbb f449ef7

Note that in the future, it's best to avoid working directly on the master branch

See "Create a branch for your future fix."
https://nixos.org/nixpkgs/manual/#submitting-changes-making-patches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants