Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh-you-should-use: init at 1.1.0 #63920

Merged
merged 1 commit into from Jul 9, 2019
Merged

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 29, 2019

Motivation for this change

Simple zsh plugin that reminds you to use existing aliases. With
oh-my-zsh it can be installed like this:

{
  programs.zsh.ohMyZsh = {
    customPkgs = [ pkgs.zsh-you-should-use ];
    plugins = [ "you-should-use" ];
  };
}
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Simple zsh plugin that reminds you to use existing aliases. With
`oh-my-zsh` it can be installed like this:

```
{
  programs.zsh.ohMyZsh = {
    customPkgs = [ pkgs.zsh-you-should-use ];
    plugins = [ "you-should-use" ];
  };
}
```
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the output

@Ma27
Copy link
Member Author

Ma27 commented Jul 9, 2019

As this is a fairly trivial package: unless there are any objections, I'd merge this tomorrow.

@Ma27 Ma27 merged commit 241a7bb into NixOS:master Jul 9, 2019
@Ma27 Ma27 deleted the package-zsh-you-should-use branch July 9, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants