Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sslsplit: init at 0.5.5 #63922

Merged
merged 1 commit into from Dec 3, 2019
Merged

sslsplit: init at 0.5.5 #63922

merged 1 commit into from Dec 3, 2019

Conversation

contrun
Copy link
Contributor

@contrun contrun commented Jun 29, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mmahut
mmahut requested changes Jun 29, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to nixpkgs :)

Beside the inline comments, the package builds fine and the binaries are working as expected. However, the sample configuration file sslsplit.conf.sample is in the root of the package, should be probably moved to doc.

pkgs/tools/networking/sslsplit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/sslsplit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/sslsplit/default.nix Show resolved Hide resolved
aanderse
aanderse requested changes Jun 30, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I have left a few minor suggestions I hope you will find helpful. And as @mmahut said, welcome!

pkgs/tools/networking/sslsplit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/sslsplit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/sslsplit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/sslsplit/default.nix Show resolved Hide resolved
@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

Any updates?

@contrun
Copy link
Contributor Author

contrun commented Aug 14, 2019

@mmahut Please see this comment #63922 (comment)

@contrun contrun changed the title sslsplit: init at 0.5.4 sslsplit: init at 0.5.5 Nov 26, 2019
@contrun
Copy link
Contributor Author

contrun commented Nov 26, 2019

@GrahamcOfBorg build sslsplit

@aanderse aanderse merged commit f4cb37f into NixOS:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@aanderse aanderse aanderse approved these changes

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@contrun @mmahut @jtojnar @aanderse