New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syncplay: 1.6.4 -> 1.6.4a, and upgrade dependency from Qt4 to Qt5 #63882
Conversation
@ofborg build syncplay |
I just noticed - I think |
@GrahamcOfBorg build |
Anything I need to do to move this forward? |
oh sorry, |
Syncplay automatically detects whether it has access to PySide, which binds Qt4, or PySide2, which binds Qt5. By simply updating the dependencies, we can upgrade Syncplay to Qt5.
b8f2dd4
to
2e677bd
Compare
I've rebased and retested, all seems ok. |
hmm, I can't run it because of:
|
I actually had the same problem, until I updated my system. I believe it's a known problem for Qt apps in general due to a mismatch between the Qt libraries you have installed in the root system vs. the ones used in an app built against nixpkgs master, but I didn't investigate deeply since updating fixed it. |
Hmm, on the other hand, looking at other issues/PRs with the same error text, it looks like there is an explicit solution with either a Qt-specific Edit: There is also a wiki page about this. |
I was able to reproduce the |
Ah I wanted to suggest something along these lines but hadn't any time to dig into it. |
Motivation for this change
It turns out Syncplay has had support for Qt5 for a while, and automatically detects whether it has access to PySide, which binds Qt4, or PySide2, which binds Qt5. By simply updating the dependencies, we can upgrade Syncplay to Qt5.
Technically the upgrade to 1.6.4a is independent, but I figured I might as well do both. If there is any reason to keep a separate Qt4 version of Syncplay around, let me know. cc @Enzime
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)