Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-tools: 2019.2 -> 2019.2.1 #63885

Merged
merged 1 commit into from Jun 29, 2019
Merged

go-tools: 2019.2 -> 2019.2.1 #63885

merged 1 commit into from Jun 29, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jun 28, 2019

Motivation for this change

Changelog: https://github.com/dominikh/go-tools/releases/tag/2019.2.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit June 28, 2019 07:07
@kalbasit
Copy link
Member

@GrahamcOfBorg build go-tools

@kalbasit kalbasit merged commit 5b7e371 into NixOS:master Jun 29, 2019
@marsam marsam deleted the update-go-tools branch June 30, 2019 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @kalbasit