Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] gnome3.gnome-control-center: fix hardcoded paths #63908

Merged
merged 2 commits into from Jun 30, 2019
Merged

[19.03] gnome3.gnome-control-center: fix hardcoded paths #63908

merged 2 commits into from Jun 30, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Fixes #63820 for what appears to be an issue for 19.03.

7b8aad4 is just another backport I thought I should do while I was here.

cc @bjornfor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added the 8.has: port to stable A PR already has a backport to the stable release. label Jun 28, 2019
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jun 28, 2019
@ofborg ofborg bot requested review from hedning and jtojnar June 28, 2019 22:16
@bjornfor bjornfor self-requested a review June 30, 2019 13:59
worldofpeace and others added 2 commits June 30, 2019 15:47
@worldofpeace
gnome3.gnome-control-center: fix hardcoded paths
7aba64f 
We're backporting fixes for the paths.patch from
f18aaa1 and a0bb3dd.

Fixes crashes because of non-existant nm-connection-editor
and the correct GNOME3 version should be displayed in the
info panel.
@jtojnar @worldofpeace
gnome3.gnome-control-center: Add mutter to dependencies
cb716d3 
make the gschemas available.

(cherry picked from commit fc4cc85)
@worldofpeace worldofpeace force-pushed the gnome-control-center-backports branch from 7b8aad4 to cb716d3 Compare June 30, 2019 19:48
@worldofpeace
Copy link
Contributor Author

Fixed a small typo in patch with the force push.

@worldofpeace worldofpeace merged commit d3d4c93 into NixOS:release-19.03 Jun 30, 2019
@worldofpeace worldofpeace deleted the gnome-control-center-backports branch June 30, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @bjornfor @jtojnar