Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fractal: fix build with gstreamer 1.16.0 #63906

Merged
merged 1 commit into from Jun 28, 2019
Merged

fractal: fix build with gstreamer 1.16.0 #63906

merged 1 commit into from Jun 28, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Jun 28, 2019 •
edited

Motivation for this change

Was going to push this one but it takes too long to build 馃槃

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from dtzWill June 28, 2019 21:57
@worldofpeace worldofpeace merged commit 8f6c65f into NixOS:master Jun 28, 2019
@worldofpeace worldofpeace deleted the fractal-fixbuild branch June 28, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@worldofpeace