redshift-wlroots: init at 1.12 #63926
Conversation
There was a problem hiding this comment.
It doesn't seem like it builds the wayland parts, as the dependencies are missing (minus7/redshift@eecbfed#diff-67e997bcfdac55191033d57a16d1408aR70) as well as the --enable-wayland configure flag.
You haven't tried to run it yet, right?
| version = "1.12"; | ||
|
|
||
| src = fetchFromGitHub { | ||
| src = fetchFromGitHub (if wlrootsSupport then { |
There was a problem hiding this comment.
It's just a single patch. If it applies to the lastest release of the proper redshift, I'd rather do that with patches = [ fetchpatch { url = "https://github.com/minus7/redshift/commit/eecbfedac48f827e96ad5e151de8f41f6cd3af66.diff"; sha256 = ""; } ]; rather than substituting the entire soruce tree.
There was a problem hiding this comment.
it applies to the latest commit on master, which is 24 commits ahead of redshift v1.12
There was a problem hiding this comment.
i agree that it's more elegant, but won't this be hard to maintain anyway in case redshift-wlroots falls behind and conflicts develop?
There was a problem hiding this comment.
@JohnAZoidberg here you go, anyway
|
it seems to work on my machine. which dependencies am i missing? |
matthias-t
force-pushed
the
master
branch
2 times, most recently
from
36b8e28
to
525d511
Compare
|
Is wayland support even added upstream? If not, I don't think we should create a new package just for this feature. |
no, see jonls/redshift#55
It's not exactly a feature, but a completely different backend, jonls/redshift#663 is open since september 2018, there seems to be no movement upstream and it's the only way to keep my eyes sane on wayland in the meantime. Although if it isn't worth a new package that's fine since I'm using my fork anyway. |
|
Yeah, something like this would be a better fit for NUR. Closing as we've converged on this. |
Motivation for this change
Make redshift available on sway and other wlroots based wayland compositors. Can be used in
services.redshift.package. See also #57602. Please review thoroughly as this is my first contribution and I have no idea what I'm doing.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)