Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packr: init at 2.5.1 #63886

Merged
merged 1 commit into from Jul 2, 2019
Merged

packr: init at 2.5.1 #63886

merged 1 commit into from Jul 2, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jun 28, 2019 •
edited

Motivation for this change

packr: init at 2.5.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Lassulus
Copy link
Member

@GrahamcOfBorg build packr

@ofborg ofborg bot requested a review from kalbasit June 28, 2019 07:40
kalbasit
kalbasit requested changes Jun 29, 2019
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change, otherwise LGTM.

pkgs/development/libraries/packr/default.nix Outdated Show resolved Hide resolved
@mmahut
Copy link
Member Author

mmahut commented Jul 1, 2019

@kalbasit thank you for the review! Rebased.

@ofborg ofborg bot requested a review from kalbasit July 1, 2019 14:43
@kalbasit
Copy link
Member

kalbasit commented Jul 2, 2019

@GrahamcOfBorg build packr

@kalbasit kalbasit merged commit 4c86dee into NixOS:master Jul 2, 2019
@thefloweringash thefloweringash mentioned this pull request Jul 9, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmahut @Lassulus @kalbasit