Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elisa: 0.3.0 -> 0.4.1 #63889

Merged
merged 1 commit into from Jul 5, 2019
Merged

elisa: 0.3.0 -> 0.4.1 #63889

merged 1 commit into from Jul 5, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

There seems to be something funky going on with QtMultimedia, so we use libvlc instead for the playback which fixes #50726

Cc: @silverhook

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@silverhook
Copy link
Contributor

Will this count as a bug-fix and land into 19.03, or fall under 19.09?

@peterhoeg
Copy link
Member Author

Normal bug fixes aren't normally backported but as a music player that doesn't actually play music is pretty useless and nothing else depends on this, I would say it's perfectly safe to do so. Can you confirm this PR is working for you?

@silverhook
Copy link
Contributor

Happy to test it, but would really need a pointer on how to do that. I’ve been using Nix(OS) for some time now, but haven’t managed to dive deeper into it and to be brutally honest, the documentation is not its best feature.

@peterhoeg
Copy link
Member Author

Do you have a local nixpkgs clone that you normally run against or are you using channels?

@JohnAZoidberg
Copy link
Member

@silverhook I'd use https://github.com/Mic92/nix-review:

nix-env -iA nix-review
nix-review pr 63889
./results/elisa/bin/elisa

@peterhoeg
Copy link
Member Author

This version works for me here, so I'll go ahead and merge it.

@peterhoeg peterhoeg merged commit 985339b into NixOS:master Jul 5, 2019
@peterhoeg peterhoeg deleted the u/elisa branch July 5, 2019 07:30
@silverhook
Copy link
Contributor

Thanks, @JohnAZoidberg, that helped a huge deal :D

@peterhoeg, I apologise for the late reply.

The window does not open, and this is what I get:

[nix-shell:~/.cache/nix-review/pr-63889]$ ./results/elisa/bin/elisa
Invalid Context= "panel" line for icon theme:  "/home/hook/.local/share/icons/Oranchelo/panel/22/"
Icon theme "gnome" not found.
QQmlApplicationEngine failed to load component
qrc:/qml/ElisaMainWindow.qml:23 plugin cannot be loaded for module "org.kde.elisa": Cannot load library /nix/store/9z77qrxnlzqak94f39phb69vag6b8gn1-elisa-0.3.0/lib/qt-5.12/qml/org/kde/elisa/libelisaqmlplugin.so: (/nix/store/9z77qrxnlzqak94f39phb69vag6b8gn1-elisa-0.3.0/lib/qt-5.12/qml/org/kde/elisa/libelisaqmlplugin.so: undefined symbol: _ZTI19AllAlbumsProxyModel)

@peterhoeg
Copy link
Member Author

That's because you cannot run qt applications directly - they have to be installed in the environment. I have just merged the backport, so you should see the new version in 19.03 soon.

@silverhook
Copy link
Contributor

I just updated NixOS and get the following error:

Invalid Context= "panel" line for icon theme:  "/home/hook/.local/share/icons/Oranchelo/panel/22/"
Icon theme "gnome" not found.
fish: 'elisa' terminated by signal SIGSEGV (Address boundary error)

@peterhoeg
Copy link
Member Author

Installed in the global environment on 19.03?

@silverhook
Copy link
Contributor

Exactly.

@peterhoeg
Copy link
Member Author

Any chance you can get a backtrace or try running it under strace?

@silverhook
Copy link
Contributor

➤ strace elisa 2> elisa-strace

fish: 'strace elisa 2> elisa-strace' terminated by signal SIGSEGV (Address boundary error)

elisa-strace.txt

@silverhook
Copy link
Contributor

@peterhoeg , just updated yesterday and tried it again, same result.

@peterhoeg
Copy link
Member Author

peterhoeg commented Aug 14, 2019 via email

@silverhook
Copy link
Contributor

@peterhoeg I can confirm it runs in the VM at least from an xterm session. Colour me surprised …

@peterhoeg
Copy link
Member Author

How about using a different user (without anything in $HOME)?

@silverhook
Copy link
Contributor

It works on 19.09 now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elisa (0.2.1) does not play music
3 participants