New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elisa: 0.3.0 -> 0.4.1 #63889
elisa: 0.3.0 -> 0.4.1 #63889
Conversation
Will this count as a bug-fix and land into 19.03, or fall under 19.09? |
Normal bug fixes aren't normally backported but as a music player that doesn't actually play music is pretty useless and nothing else depends on this, I would say it's perfectly safe to do so. Can you confirm this PR is working for you? |
Happy to test it, but would really need a pointer on how to do that. I’ve been using Nix(OS) for some time now, but haven’t managed to dive deeper into it and to be brutally honest, the documentation is not its best feature. |
Do you have a local nixpkgs clone that you normally run against or are you using channels? |
Also fixes NixOS#50726
@silverhook I'd use https://github.com/Mic92/nix-review: nix-env -iA nix-review
nix-review pr 63889
./results/elisa/bin/elisa |
This version works for me here, so I'll go ahead and merge it. |
Thanks, @JohnAZoidberg, that helped a huge deal :D @peterhoeg, I apologise for the late reply. The window does not open, and this is what I get:
|
That's because you cannot run qt applications directly - they have to be installed in the environment. I have just merged the backport, so you should see the new version in 19.03 soon. |
I just updated NixOS and get the following error:
|
Installed in the global environment on 19.03? |
Exactly. |
Any chance you can get a backtrace or try running it under strace? |
➤ strace elisa 2> elisa-strace
fish: 'strace elisa 2> elisa-strace' terminated by signal SIGSEGV (Address boundary error) |
@peterhoeg , just updated yesterday and tried it again, same result. |
@peterhoeg , just updated yesterday and tried it again, same result.
I don't know what to tell you - elisa works in a VM with 19.03 on my side.
Could you possibly try with a new/temporary user profile or alternatively using "nixos-rebuild build-vm" with a minimal configuration?
|
@peterhoeg I can confirm it runs in the VM at least from an xterm session. Colour me surprised … |
How about using a different user (without anything in $HOME)? |
It works on 19.09 now :) |
Motivation for this change
There seems to be something funky going on with QtMultimedia, so we use libvlc instead for the playback which fixes #50726
Cc: @silverhook
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)