checkStoreName: give more precise/verbose error information #2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edolstra
reviewed
Jun 27, 2019
src/libstore/store-api.cc
Outdated
| "Path names are alphanumeric and can include the symbols %1% " | ||
| "and must not begin with a period. " | ||
| "Note: If you cannot rename '%2%', builtins.path { name = ... } " | ||
| "can be used to give it an alternative name.") % validChars % name; |
There was a problem hiding this comment.
That means that you can rename it :-) Also, the builtins.path advice is only applicable for sources.
$ sudo ./inst/bin/nix-instantiate -E '"${./.git}"'
error: The path name '.git' is invalid: it is illegal to start the
name with a period. Path names are alphanumeric and can include the
symbols +-._?= and must not begin with a period. Note: If '.git' is a
source file and you cannot rename it on disk,
builtins.path { name = ... } can be used to give it an alternative
name.
edolstra
reviewed
Jul 2, 2019
| @@ -86,18 +86,25 @@ string storePathToHash(const Path & path) | |||
| void checkStoreName(const string & name) | |||
| { | |||
| string validChars = "+-._?="; | |||
|
|
|||
| auto baseError = format("The path name '%2%' is invalid: %3%. " | |||
There was a problem hiding this comment.
Please use fmt("<format-string>", args...) in new code.
There was a problem hiding this comment.
Right now I depend on the final substitution being "curried", is there a way to support that, or should I not do the partial application?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2973