Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guardian-agent: init at 0.7.2-beta #63898

Merged
merged 1 commit into from Jul 16, 2019
Merged

guardian-agent: init at 0.7.2-beta #63898

merged 1 commit into from Jul 16, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jun 28, 2019

Motivation for this change

guardian-agent: init at 0.7.2-beta

Fixes #63834.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Jul 6, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've left some suggestions and some comments to clarify.

pkgs/tools/networking/guardian-agent/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/guardian-agent/default.nix Show resolved Hide resolved
pkgs/tools/networking/guardian-agent/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/guardian-agent/default.nix Show resolved Hide resolved
pkgs/tools/networking/guardian-agent/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/guardian-agent/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/guardian-agent/default.nix Outdated Show resolved Hide resolved
@mmahut mmahut force-pushed the guardian-agent branch 2 times, most recently from ab797ed to 7806b4f Compare July 7, 2019 18:48
@worldofpeace
Copy link
Contributor

After looking at that script I still thing we should be wrapping it with wrapProgram like #63898 (comment).

Why didn't it work for you?

@worldofpeace worldofpeace merged commit ac94237 into NixOS:master Jul 16, 2019
@mmahut mmahut deleted the guardian-agent branch July 16, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package guardian-agent
2 participants
@mmahut @worldofpeace