Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-tor-exporter: 0.3 -> 0.4 #63891

Merged
merged 1 commit into from Jul 5, 2019
Merged

prometheus-tor-exporter: 0.3 -> 0.4 #63891

merged 1 commit into from Jul 5, 2019

Conversation

priegger
Copy link
Contributor

Motivation for this change

This fixes #63831. From the ticket:

The prometheus-tor-exporter gives a stack trace and the following error in the journal:

stem.OperationFailed: Not running in server mode

This seems to be a "stem 1.7+ compatibility" issue fixed in 0.4.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mmahut
mmahut approved these changes Jun 29, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build evals
  • run nix-review without any failures
  • run and tested the binaries

@veprbl
Copy link
Member

veprbl commented Jul 3, 2019

cc @delroth
@GrahamcOfBorg build prometheus-tor-exporter

@delroth
Copy link
Contributor

delroth commented Jul 3, 2019

I'll test this on my infra tonight and report back. Thanks for the PR!

@delroth
Copy link
Contributor

delroth commented Jul 5, 2019

LGTM

@veprbl veprbl merged commit 698f3e9 into NixOS:master Jul 5, 2019
@priegger priegger deleted the prometheus-tor-exporter branch July 7, 2019 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update prometheus-tor-exporter to v0.4
4 participants
@priegger @veprbl @delroth @mmahut