Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for power/running cost sorting algorithm. #7561

Closed
dorobouNeko opened this issue May 3, 2019 · 1 comment
Closed

Fix for power/running cost sorting algorithm. #7561

dorobouNeko opened this issue May 3, 2019 · 1 comment

Comments

@dorobouNeko
Copy link
Contributor

The algorithm assumes that running cost (in GBP) is always higher than power, which is not always true.
Solution would be to make the division and compare two floats, with enough precision. Also take into account zero running cost when dividing.
I would code this but my c++ is kinda rusty and i bet someone else could make this much more elegant and consistent with the project.
dorobouNeko added a commit to dorobouNeko/OpenTTD that referenced this issue May 5, 2019
@dorobouNeko
Fix OpenTTD#7561: Remove assumption between power and cost
0bbce5b
dorobouNeko added a commit to dorobouNeko/OpenTTD that referenced this issue May 5, 2019
@dorobouNeko
Fix OpenTTD#7561: Add float casts to division integers
2895de1
dorobouNeko added a commit to dorobouNeko/OpenTTD that referenced this issue May 5, 2019
@dorobouNeko
Fix OpenTTD#7561: Change floats to double for more precision
dcffd3a
dorobouNeko added a commit to dorobouNeko/OpenTTD that referenced this issue May 6, 2019
@dorobouNeko
Fix OpenTTD#7561: Add more comments and simplify some boolean logic
fb08ad5
dorobouNeko added a commit to dorobouNeko/OpenTTD that referenced this issue May 6, 2019
@dorobouNeko
Fix OpenTTD#7561: More comments and simplify more logic
b94200d
dorobouNeko added a commit to dorobouNeko/OpenTTD that referenced this issue May 6, 2019
@dorobouNeko
Fix OpenTTD#7561: Change bitwise operator XOR(^) for equivalent logic…
20dd509 
… one not-equal (!=)
dorobouNeko added a commit to dorobouNeko/OpenTTD that referenced this issue May 6, 2019
@dorobouNeko
Fix OpenTTD#7561: Remove old comment about bitwise operator
0be404f
dorobouNeko added a commit to dorobouNeko/OpenTTD that referenced this issue May 6, 2019
@dorobouNeko
Fix OpenTTD#7561: Add comment on why floating-point operation are acc…
a8550b3 
…eptable
dorobouNeko added a commit to dorobouNeko/OpenTTD that referenced this issue May 6, 2019
@dorobouNeko
Fix OpenTTD#7561: Add more complete comment on why use ID sorter
b4fea1c
dorobouNeko added a commit to dorobouNeko/OpenTTD that referenced this issue May 6, 2019
@dorobouNeko
Fix OpenTTD#7561: Fix some coding style mistakes
c80948b
dorobouNeko added a commit to dorobouNeko/OpenTTD that referenced this issue May 6, 2019
@dorobouNeko
Fix OpenTTD#7561: Fix power/running cost vehicle engine sorter
1cf644b
dorobouNeko added a commit to dorobouNeko/OpenTTD that referenced this issue May 6, 2019
@dorobouNeko
Fix OpenTTD#7561: Fix power/running cost vehicle engine sorter
817aaa5
dorobouNeko added a commit to dorobouNeko/OpenTTD that referenced this issue May 14, 2019
@dorobouNeko
Fix OpenTTD#7561: Fix to sort like previously for wagons
d73c9e3
dorobouNeko added a commit to dorobouNeko/OpenTTD that referenced this issue May 16, 2019
@dorobouNeko
Fix OpenTTD#7561: Fix to sort like previously for wagons
53f2c8e
dorobouNeko added a commit to dorobouNeko/OpenTTD that referenced this issue May 16, 2019
@dorobouNeko
Fix OpenTTD#7561: Fix power/running cost vehicle engine sorter
0f8ec4d
@MingweiSamuel
Copy link
Contributor

(link: #7573)

dorobouNeko added a commit to dorobouNeko/OpenTTD that referenced this issue Jun 9, 2019
@dorobouNeko
Fix OpenTTD#7561: Fix power/running cost vehicle engine sorter
1a16521
dorobouNeko added a commit to dorobouNeko/OpenTTD that referenced this issue Jun 9, 2019
@dorobouNeko
Fix OpenTTD#7561: Fix power/running-cost vehicle sorter
5d40b0b
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@dorobouNeko @douiwby
Fix OpenTTD#7561: Fix power/running-cost vehicle sorter
485544c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MingweiSamuel @dorobouNeko