Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Default setting of "Advertise" in server browser to "Yes" #7568

Merged
merged 1 commit into from May 5, 2019

Conversation

Hexus-One
Copy link
Contributor

When I first downloaded and launched OpenTTD a few years ago, I was confused that no multiplayer servers were showing. After 20 minutes of research I figured that I had to change this one option to "Yes". I feel that many other players have suffered this problem, and some may even be entirely turned off playing the game because of this.

I propose we change the default option to "Yes" so new players have an easier time browsing and playing online.

@V453000
Copy link

V453000 commented May 4, 2019

Makes a lot of sense to me :)

@Hexus-One Hexus-One force-pushed the server-advertise branch 2 times, most recently from 89737b2 to b5864e6 Compare May 4, 2019 18:18
@LordAro
Copy link
Member

LordAro commented May 4, 2019

Looks like your gitconfig might need a little work - GH doesn't recognise your commit as being from your account - is the email address wrong/missing? Would be good if you could fix that

@Hexus-One
Copy link
Contributor Author

Looks like your gitconfig might need a little work - GH doesn't recognise your commit as being from your account - is the email address wrong/missing? Would be good if you could fix that

Author changed to the correct author :)

@PeterN PeterN merged commit 4d0ee65 into OpenTTD:master May 5, 2019
@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label May 28, 2019
@LordAro
Copy link
Member

LordAro commented May 28, 2019

It's a change, but a small one, and improves usability as well - perhaps should be backported?

michicc pushed a commit to michicc/OpenTTD that referenced this pull request Jun 30, 2019
@michicc michicc added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Jul 14, 2019
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants