Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong variable 'traffic_side' #36

Closed
kiwitreekor opened this issue May 4, 2019 · 2 comments
Closed

Wrong variable 'traffic_side' #36

kiwitreekor opened this issue May 4, 2019 · 2 comments

Comments

@kiwitreekor
Copy link

VarAction2 variable 0x06 is 0x10 when traffic side is right, not 0x01.
@Eddi-z
Copy link
Contributor

Eddi-z commented May 4, 2019 •
edited

I don't see why you think it's wrong.

The variable traffic_side is not VarAction2 variable 0x06, but VarAction2 variable 0x06, bit 4, and thus the valid values are 0 and 1. Also, you're meant to check against TRAFFIC_SIDE_LEFT and TRAFFIC_SIDE_RIGHT and not be bothered with the numeric values.

Eddi-z added a commit to Eddi-z/nml that referenced this issue May 4, 2019
@Eddi-z
Fix OpenTTD#36: global variable traffic_side was inconsistent with gl…
859dc3f 
…obal parameter traffic_side
@Eddi-z
Copy link
Contributor

Eddi-z commented May 4, 2019

i see it now...

@michicc michicc closed this as completed in 554b458 May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kiwitreekor @Eddi-z