Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

krunner-pass: fix the build #60829

Merged
merged 1 commit into from May 3, 2019
Merged

krunner-pass: fix the build #60829

merged 1 commit into from May 3, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Fixes #59355

Cc: @seqizz @worldofpeace

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace approved these changes May 3, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch upstream looks correct, all changes here to reflect that were made 👍

One thing though, I don't think patches from patch-diff.githubusercontent.com are stable until merged.
So maybe fetch from your fork
https://github.com/peterhoeg/krunner-pass/commit/be2695f4ae74b0cccec8294defcc92758583d96b.patch
or use it locally?

@peterhoeg peterhoeg merged commit 4c56c1c into NixOS:master May 3, 2019
@peterhoeg peterhoeg deleted the f/krunner_pass branch May 3, 2019 07:49
@peterhoeg
Copy link
Member Author

Thanks for the pointer on patch-diff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

krunner-pass build failure
2 participants
@peterhoeg @worldofpeace