Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better reference plane for the the ECI etc. frames. #2153

Merged
merged 9 commits into from
May 13, 2019

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented May 5, 2019

This will make it possible to address #1841; additional logic would be needed for to properly address the irrelevance of the solar equator, other than that this is a simple matter of changing the following condition in the adapter.

if (frame_type ==
ReferenceFrameSelector.FrameType.BARYCENTRIC_ROTATING ||
frame_type == ReferenceFrameSelector.FrameType
.BODY_CENTRED_PARENT_DIRECTION) {

Note: this breaks tests (some values that were very small have become 0 because of the changes in (bi)equatorial), and it probably needs some new tests to check the orientation.

eggrobin added 7 commits May 5, 2019 21:52

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
// In coordinates, the third parameter is |polar_axis|, but we seem
// to be a bit confused as to which of these things should be
// vectors or bivectors here.
// TODO(egg): Figure that out.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels reasonable to use a bivector for the axis. I think we have a similar "confused" comment somewhere else.

@pleroy pleroy added the LGTM label May 13, 2019
@eggrobin eggrobin merged commit 8599650 into mockingbirdnest:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants