Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-sweep: init at 0.4.1 #59557

Merged
merged 1 commit into from Apr 25, 2019
Merged

cargo-sweep: init at 0.4.1 #59557

merged 1 commit into from Apr 25, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Apr 15, 2019

Motivation for this change

A Cargo subcommand for cleaning up unused build files generated by Cargo.
https://github.com/holmgr/cargo-sweep

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Apr 16, 2019

@GrahamcOfBorg build cargo-sweep

@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 21, 2019

Hello @FRidh, thanks for the review!
Please tell me if there is any other improvement I can do.

@c0bw3b c0bw3b merged commit 526a406 into NixOS:master Apr 25, 2019
@xrelkd xrelkd deleted the add/cargo-sweep branch April 26, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants