Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/deepin-turbo: init #59560

Closed
wants to merge 1 commit into from
Closed

nixos/deepin-turbo: init #59560

wants to merge 1 commit into from

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Apr 15, 2019

Motivation for this change

Add a NixOS module for the deepin-turbo package.

About packaging deepin for NixOS: #59023

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo romildo requested a review from infinisil as a code owner April 15, 2019 03:58
@infinisil
Copy link
Member

Couldn't you make it a single module with all deepin options? Maybe you could even use a single option for all of them too then. I'm not a big fan of these trivial modules, but if they're bunched together that sounds much better.

@infinisil infinisil mentioned this pull request Apr 15, 2019
Merged
10 tasks
@worldofpeace
Copy link
Contributor

Couldn't you make it a single module with all deepin options? Maybe you could even use a single option for all of them too then. I'm not a big fan of these trivial modules, but if they're bunched together that sounds much better.

We've discussed this in IRC, and there's certain things that we need a single module for (deepin-menu).
See also #59023 (comment)

For the deepin desktop specific pieces it could mostly be in the desktopManager module.
Though having things broken up is easier to maintain.

@infinisil
Copy link
Member

I see, but it would still be possible to put all these related options into a single module, instead of having a bunch of 10-line modules that all look and do almost the same.

@romildo
Copy link
Contributor Author

romildo commented Apr 21, 2019

Closed in favor of #59943.

@romildo romildo closed this Apr 21, 2019
@romildo romildo mentioned this pull request Apr 21, 2019
Merged
10 tasks
@romildo romildo deleted the upd.deepin.deepin-turbo branch June 11, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romildo @infinisil @worldofpeace @GrahamcOfBorg