New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hpack-convert: 1.0.1 -> 1.0.2 #59438
Conversation
@expipiplus1 Could you please rebase this? |
fd28f02
to
decc031
Compare
@aanderse rebased |
1.0.1 does not compile with the current package set
decc031
to
33c78e4
Compare
# Get hpack-convert to compile with the versions of its dependencies in nixpkgs. | ||
# The tests are still broken | ||
hpack-convert = dontCheck (overrideSrc super.hpack-convert { | ||
version = "1.0.2"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see, 1.0.2 is not released? https://github.com/yamadapc/hpack-convert/releases
I don't think its been released, I'm not sure how actively the package is maintained on Hackage.
What's the nixpkgs policy on using unreleased versions of Haskell packages? Perhaps this would be more appropriate as a patch on the 1.0.1 release.
…-----Original Message-----
From: "Aaron Andersen" <notifications@github.com>
Sent: 17/05/2019 00:08
To: "NixOS/nixpkgs" <nixpkgs@noreply.github.com>
Cc: "Joe Hermaszewski" <joe@monoid.al>; "Mention" <mention@noreply.github.com>
Subject: Re: [NixOS/nixpkgs] hpack-convert: 1.0.1 -> 1.0.2 (#59438)
@expipiplus1 ping #59438 (comment)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I suggest to only use the patch that actually fixes the error. What is the error anyways? And the package in nixpkgs will automatically be updated to the newest version once released on hackage. |
@infinisil by patch, I meant the same code but expressed as a patch against what's on hackage instead of a reference to a git tree, so no real difference. The error, just bitrot:
|
This PR appears to be over a year old, so I am going to go ahead and close it. But if you'd still like to see this fixed up, please feel free to open a new PR against the current |
1.0.1 does not compile with the current package set
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)