Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adoptopenjdk: add version 12 #59386

Closed
wants to merge 1 commit into from
Closed

adoptopenjdk: add version 12 #59386

wants to merge 1 commit into from

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Apr 13, 2019

Motivation for this change

Add AdoptOpenJDK 12. We keep 11 since it is LTS version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@taku0
Copy link
Contributor Author

taku0 commented Apr 21, 2019

This will conflict with #59951. When #59951 is merged, I will update the branch.

@taku0
Copy link
Contributor Author

taku0 commented Apr 27, 2019

Updated

@taku0
Copy link
Contributor Author

taku0 commented Apr 27, 2019

This again conflicts with #60224. I will update when it is merged.

@aanderse
Copy link
Member

This again conflicts with #60224. I will update when it is merged.

Good to go 👍

@Gaelan
Copy link
Contributor

Gaelan commented May 10, 2020

adoptopenjdk 13 is now in Nixpkgs. Is there any reason we still need/want 12?

@wamserma
Copy link
Member

I also think this PR can be retired. @taku0 any reasons to keep?

@taku0
Copy link
Contributor Author

taku0 commented May 23, 2020

Closing this.

@taku0 taku0 closed this May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@taku0 @aanderse @Gaelan @wamserma @GrahamcOfBorg