Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/fprintd: use systemd.packages #59480

Merged
merged 1 commit into from May 13, 2019

Conversation

worldofpeace
Copy link
Contributor

Upstream has a systemd service.

Motivation for this change

Noticed all the nice restrictions they've done to this.

I think a backport would be good idea as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Upstream has a systemd service.
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed upstream provide a fine-tuned service unit description

@worldofpeace
Copy link
Contributor Author

Did you test that the service still worked @c0bw3b? (though I don't expect there to be a problem)

@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 25, 2019

No I have not. I'll let you know if I come around to testing it later.

@worldofpeace
Copy link
Contributor Author

Going for it 😄

@worldofpeace worldofpeace merged commit b5f26f3 into NixOS:master May 13, 2019
@worldofpeace worldofpeace deleted the fprintd-systemd branch May 13, 2019 07:30
@jtojnar jtojnar mentioned this pull request Feb 25, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants