Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marisa: 0.2.4 -> 0.2.5 #59486

Merged
merged 1 commit into from Apr 14, 2019
Merged

marisa: 0.2.4 -> 0.2.5 #59486

merged 1 commit into from Apr 14, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Apr 14, 2019

Motivation for this change

Update marisa to the latest release.

https://github.com/s-yata/marisa-trie/releases/tag/v0.2.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Apr 14, 2019

@GrahamcOfBorg build marisa

@xeji
Copy link
Contributor

xeji commented Apr 14, 2019

local nix-review shows no issues

@xeji
Copy link
Contributor

xeji commented Apr 14, 2019

no point in waiting for darwin, it's totally broken atm

@xeji xeji merged commit e3cad1e into NixOS:master Apr 14, 2019
@xrelkd xrelkd deleted the update/marisa branch April 15, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xrelkd @xeji @infinisil @GrahamcOfBorg