Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Python syntax #16349

Merged
merged 1 commit into from Apr 16, 2019
Merged

Update Python syntax #16349

merged 1 commit into from Apr 16, 2019

Conversation

gsnedders
Copy link
Member

From pyupgrade==1.16.0.

This is mostly using dict/set comprehensions where possible, and dealing
with escape sequences that become invalid in Python 3.8.

@gsnedders
Update Python syntax
e0cb9de 
From pyupgrade==1.16.0.

This is mostly using dict/set comprehensions where possible, and dealing
with escape sequences that become invalid in Python 3.8.
@wpt-pr-bot wpt-pr-bot added ci infra lint manifest pywebsocket runner The web-based tools/runner/ serve wpt wptrunner The automated test runner, commonly called through ./wpt run wptserve labels Apr 15, 2019
@jugglinmike
Copy link
Contributor

Can we add pyupgrade to the CI lint task?

Ms2ger
Ms2ger approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think the set comprehension changes were really needed, but ok.

@gsnedders
Copy link
Member Author

@jugglinmike it's… slightly awkward. find tools/ -name third_party -prune -o -name 'invalid.py' -prune -o -name '*.py' -print0 | xargs -0 pyupgrade --keep-percent-format is what I ran, which isn't… great.

@gsnedders gsnedders merged commit 536f776 into web-platform-tests:master Apr 16, 2019
@gsnedders gsnedders deleted the pyupgrade branch April 16, 2019 14:14
@jugglinmike jugglinmike mentioned this pull request Apr 16, 2019
Merged
marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
@gsnedders
Update Python syntax (#16349)
eeb76c4 
From pyupgrade==1.16.0.

This is mostly using dict/set comprehensions where possible, and dealing
with escape sequences that become invalid in Python 3.8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

@jgraham jgraham Awaiting requested review from jgraham

@jugglinmike jugglinmike Awaiting requested review from jugglinmike

Assignees

@jugglinmike jugglinmike

Labels
ci infra lint manifest pywebsocket runner The web-based tools/runner/ serve wpt wptrunner The automated test runner, commonly called through ./wpt run wptserve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gsnedders @jugglinmike @Ms2ger @wpt-pr-bot